Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predict_image_object_detection_sample.py uses wrong parameter format #147

Closed
Crash-GHaun opened this issue Dec 22, 2020 · 3 comments · Fixed by #150
Closed

predict_image_object_detection_sample.py uses wrong parameter format #147

Crash-GHaun opened this issue Dec 22, 2020 · 3 comments · Fixed by #150
Assignees
@dizcology
Labels
samples Issues that are directly related to samples.

Comments

@Crash-GHaun
Copy link

  • OS type and version: Debian GNU/ Linux 10
  • Python version: 3.7
  • pip version: 20.2.4
  • google-cloud-aiplatform version: 0.3.1

Steps to reproduce

Line 45 in predict_image_object_detection_sample.py

Parameters have no effect because of "_". Need to change to camalCase

Code example

If available to you: https://github.com/googleapis/python-aiplatform/compare/master...Crash-GHaun:patch-1?expand=1

Following process to create bug before pull request
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2020
@Crash-GHaun Crash-GHaun mentioned this issue Dec 22, 2020
Closed
@dizcology dizcology self-assigned this Dec 22, 2020
@dizcology dizcology mentioned this issue Dec 22, 2020
Merged
@dizcology
Copy link
Contributor

@Crash-GHaun Thank you for reporting the issue!

@Crash-GHaun
Copy link
Author

Anytime! Quick question on this, will this update propagate to the documentation on the website?

If not I'll make sure it get's changed there too :)

@dizcology
Copy link
Contributor

I think the documentation should get updated automatically after a few minutes, I will keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dizcology dizcology

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
2 participants
@dizcology @Crash-GHaun