Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add holiday regions for vertex forecasting #1253

Merged
merged 7 commits into from
May 27, 2022
Merged

feat: add holiday regions for vertex forecasting #1253

merged 7 commits into from
May 27, 2022

Conversation

TheMichaelHu
Copy link
Contributor

@TheMichaelHu TheMichaelHu commented May 24, 2022 •
edited
Loading

Add holiday regions for Vertex Forecasting.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/232964228 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels May 24, 2022
@TheMichaelHu TheMichaelHu changed the title Mh holidays feat: add holiday regions for vertex forecasting May 24, 2022
@TheMichaelHu TheMichaelHu requested a review from ivanmkc May 24, 2022 19:16
@TheMichaelHu TheMichaelHu requested a review from ivanmkc May 25, 2022 15:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 25, 2022
ivanmkc
ivanmkc approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
@TheMichaelHu TheMichaelHu added the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0036ab0 into googleapis:main May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@release-please release-please bot mentioned this pull request May 27, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

Assignees

@ivanmkc ivanmkc

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMichaelHu @ivanmkc