Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add batch_size kwarg for batch prediction jobs #1194

Merged
merged 7 commits into from
May 10, 2022
Merged

Feat: add batch_size kwarg for batch prediction jobs #1194

merged 7 commits into from
May 10, 2022

Conversation

jaycee-li
Copy link
Contributor

@jaycee-li jaycee-li commented May 4, 2022 •
edited
Loading

Fixes #525

Add batch_size kwarg for batch prediction jobs

@jaycee-li jaycee-li added the aiplatform Issues related to the AI Platform (Unified) API. label May 4, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 4, 2022
@jaycee-li jaycee-li requested a review from sasha-gitg May 4, 2022 17:16
@jaycee-li jaycee-li changed the title Add batch_size kwarg for batch prediction jobs Fix: add batch_size kwarg for batch prediction jobs May 4, 2022
@jaycee-li jaycee-li changed the title Fix: add batch_size kwarg for batch prediction jobs Feat: add batch_size kwarg for batch prediction jobs May 4, 2022
sasha-gitg
sasha-gitg reviewed May 4, 2022
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly LGTM! Minor comments.

google/cloud/aiplatform/jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
sasha-gitg
sasha-gitg reviewed May 4, 2022
View reviewed changes
google/cloud/aiplatform/jobs.py Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
@jaycee-li
Fix errors
a7b98b3 
Update the copyright year. Change the order of the argument. Fix the syntax error.
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 5, 2022
@sararob sararob added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 5, 2022
@sararob sararob removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2022
@jaycee-li jaycee-li merged commit 50bdb01 into googleapis:main May 10, 2022
@release-please release-please bot mentioned this pull request May 10, 2022
Merged
@rlucioni
Copy link

@jaycee-li any chance we can get 1.13.1 pushed to PyPI? We'd love access to the batch_size kwarg. I see #1216 has been sitting for over a week.

@jaycee-li
Copy link
Contributor Author

@rlucioni I can ask the team to release 1.13.1 next week.

@rlucioni
Copy link

That'd be great, thanks!

@jaycee-li
Copy link
Contributor Author

@rlucioni
Hi Renzo, after discussing with the team, we decide not to release the patch version 1.13.1 since there is no urgent bug fix in this patch. We'll schedule to release 1.14.0 in two weeks.

The batch_size kwarg has been added to our main repo. So if you want to use it now, you can install from Github main branch: pip3 install --force-reinstall git+https://github.com/googleapis/python-aiplatform.git@main

Sorry for the inconvenience!

@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
aiplatform Issues related to the AI Platform (Unified) API. api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support specifying batch_size when submitting batch predict jobs
4 participants
@jaycee-li @rlucioni @sasha-gitg @sararob