Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update model code snippet order in README #1154

Merged
merged 4 commits into from
Apr 11, 2022
Merged

docs: update model code snippet order in README #1154

merged 4 commits into from
Apr 11, 2022

Conversation

nayaknishant
Copy link
Contributor

Changing order of model code snippets, so model is retrieved first before doing the calls.

@nayaknishant nayaknishant requested a review from a team as a code owner April 8, 2022 22:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 8, 2022
yil532
yil532 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@yil532 yil532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Proper order change of the code sample.

@nayaknishant nayaknishant merged commit 404d7f1 into main Apr 11, 2022
@nayaknishant nayaknishant deleted the nn-readme-patch branch April 11, 2022 20:59
@release-please release-please bot mentioned this pull request Apr 11, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yil532 yil532 yil532 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayaknishant @yil532 @parthea