Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: GA launch for PersonDetection and FaceDetection features #482

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 12, 2020

Refs: #477

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2020
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2020
@bcoe
Copy link
Contributor Author

bcoe commented Oct 13, 2020

Talking with @telpirion, it sounds like we potentially have some breaking changes we might want to call out in the next release of face detection.

Working to figure out if this is actually already broken, and causing:

#480

@product-auto-label product-auto-label bot added the api: videointelligence Issues related to the googleapis/nodejs-video-intelligence API. label Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files          14       14           
  Lines        2950     2950           
  Branches      190      190           
=======================================
  Hits         2795     2795           
  Misses        149      149           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434fd4b...b6f3d99. Read the comment docs.

@bcoe bcoe merged commit 6994bb0 into master Oct 29, 2020
@bcoe bcoe deleted the face-detection branch October 29, 2020 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: videointelligence Issues related to the googleapis/nodejs-video-intelligence API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants