Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add support for 'fields' query parameter to getFiles #2521

Merged
merged 13 commits into from
Sep 17, 2024
Merged

feat(storage): add support for 'fields' query parameter to getFiles #2521

merged 13 commits into from
Sep 17, 2024
+43 −1

Conversation

thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2138

thiyaguk09 and others added 13 commits September 6, 2024 15:26
@thiyaguk09
feature added
e28ce5f
@thiyaguk09
fix
83de827
@thiyaguk09
Added system test and sample test cases
828b645
@thiyaguk09
copyright fix
164975a
@thiyaguk09
Merge pull request #1 from thiyaguk09/googleapis#2138-feature-add-'fi…
f6f8e48 
…elds'-to-getFiles

feat(storage):  add support for 'fields' query parameter to getFiles
@thiyaguk09
Merge branch 'main' of https://github.com/thiyaguk09/nodejs-storage-fork
b466a7d
@thiyaguk09
build: fix path-to-regexp to older version due to node 14 requirement
41261d8
@thiyaguk09
Merge pull request #2 from thiyaguk09/googleapis#2138-feature-add-'fi…
99e7acd 
…elds'-to-getFiles

build: fix path-to-regexp to older version due to node 14 requirement
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
65aaf97 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@thiyaguk09
Remove unnecessary sample code
5b1a681
@thiyaguk09
Merge pull request #3 from thiyaguk09/googleapis#2138-feature-add-'fi…
af6adf9 
…elds'-to-getFiles

Remove unnecessary sample code
@thiyaguk09
Merge branch 'main' of https://github.com/thiyaguk09/nodejs-storage-fork
5336628
@thiyaguk09
Manually modify README regards remove unnecessary sample code
e93bc98
@thiyaguk09 thiyaguk09 requested review from a team as code owners September 17, 2024 08:11
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 17, 2024
thiyaguk09
thiyaguk09 commented Sep 17, 2024
View reviewed changes
system-test/common.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We adjusted the test placement to address the previous failures.

ddelgrosso1
ddelgrosso1 reviewed Sep 17, 2024
View reviewed changes
package.json
@@ -122,6 +122,8 @@
"pack-n-play": "^2.0.0",
"proxyquire": "^2.1.3",
"sinon": "^18.0.0",
"nise": "6.0.0",
"path-to-regexp": "6.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add a tacking issue to remove this once we upgrade to Node 18 minimum so we don't forget.

ddelgrosso1
ddelgrosso1 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@danielduhh danielduhh mentioned this pull request Sep 17, 2024
Closed
@ddelgrosso1 ddelgrosso1 mentioned this pull request Sep 17, 2024
Open
@ddelgrosso1 ddelgrosso1 merged commit f78fe92 into googleapis:main Sep 17, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: add support for 'fields' query parameter to getFiles
2 participants
@thiyaguk09 @ddelgrosso1