Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(retry): export RETRYABLE_ERR_FN_DEFAULT #2517

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(retry): export RETRYABLE_ERR_FN_DEFAULT #2517

merged 1 commit into from
Sep 17, 2024

Conversation

Cynocracy
Copy link
Contributor

Fixes #2516

@Cynocracy Cynocracy requested review from a team as code owners September 3, 2024 21:59
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 3, 2024
@Cynocracy Cynocracy changed the title export RETRYABLE_ERR_FN_DEFAULT feat(retry): export RETRYABLE_ERR_FN_DEFAULT Sep 3, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ddelgrosso1
Copy link
Contributor

Thank you for the contribution @Cynocracy. One small request, can you amend the commit to be fix instead of retry. This likely should have been exported previously.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2024
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2024
@ddelgrosso1
Copy link
Contributor

Apologies, see my comments on the issue.

@Cynocracy
Copy link
Contributor Author

roger, will continue discussion in the issue

@ddelgrosso1
Copy link
Contributor

Ok I'm good with exporting this. If you can just update the commit message I can get this merged / released.

@Cynocracy
Copy link
Contributor Author

@ddelgrosso1 thanks! Updating it now

@Cynocracy Cynocracy changed the title feat(retry): export RETRYABLE_ERR_FN_DEFAULT fix(retry): export RETRYABLE_ERR_FN_DEFAULT Sep 16, 2024
@ddelgrosso1
Copy link
Contributor

Failures are not related to anything you did. This is being fixed in another PR.

@ddelgrosso1
Copy link
Contributor

@Cynocracy if you merge main into your branch this should now pass the CI tests and we can merge.

@Cynocracy
fix(retry): export RETRYABLE_ERR_FN_DEFAULT
4ab7bda 
Without this, it's difficult to create an informational/delegated retry function, that wraps the default and logs the outcome / does some additional logic
@Cynocracy
Copy link
Contributor Author

Cynocracy commented Sep 17, 2024 •
edited
Loading

updated! and ty for the info :)

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@ddelgrosso1
Copy link
Contributor

Thanks for the contribution @Cynocracy. I'll release this with 7.13.0 first thing tomorrow.

@ddelgrosso1 ddelgrosso1 merged commit db890fd into googleapis:main Sep 17, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Sep 17, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 19, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import RETRYABLE_ERR_FN_DEFAULT
3 participants
@Cynocracy @ddelgrosso1 @yoshi-kokoro