Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing projectIdentifier to GetServiceAccountOptions #2468

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: add missing projectIdentifier to GetServiceAccountOptions #2468

merged 1 commit into from
May 13, 2024

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2446 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 13, 2024 16:53
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 13, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2024
@ddelgrosso1 ddelgrosso1 merged commit d49e9d2 into googleapis:main May 13, 2024
16 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix-service-account-opts branch May 13, 2024 17:16
@release-please release-please bot mentioned this pull request May 13, 2024
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 17, 2024
Closed
This was referenced Jul 27, 2024
Open
Open
@polly-parrot polly-parrot mentioned this pull request Aug 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduhh danielduhh danielduhh approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetServiceAccountOptions missing projectIdentifier field
2 participants
@ddelgrosso1 @danielduhh