Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(deps): Consideration of removing an unnecessary dependency (abort-controller) #2211

Open
SandZn opened this issue Jun 4, 2023 · 3 comments
Open

cleanup(deps): Consideration of removing an unnecessary dependency (abort-controller) #2211

SandZn opened this issue Jun 4, 2023 · 3 comments
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.

Comments

@SandZn
Copy link

SandZn commented Jun 4, 2023

Hi,

I'm doing research on detecting unnecessary dependencies in NodeJs packages. I found that one dependency (abort-controller) is not necessary for your package.

I modified the package.json file to remove the abort-controller dependency, and I ran your tests. The testing result showed that all tests passed, and the test coverage did not change before and after I removed this dependency.

Would you consider removing this dependency to enhance security and reduce maintenance costs?
@SandZn SandZn added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 4, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 4, 2023
@ddelgrosso1
Copy link
Contributor

Hi @SandZn unfortunately I do not think this is possible at this time. This library currently supports Node >= 12. AbortController did not become stable in Node until v15.4.0 . I am assuming you tested with a version >= 15.4.0 is that correct?

@ddelgrosso1 ddelgrosso1 self-assigned this Jun 5, 2023
@SandZn
Copy link
Author

SandZn commented Jun 5, 2023

Correct. My node version is v16.17.0. Thank you for your response.

@ddelgrosso1
Copy link
Contributor

@SandZn I'm going to keep this issue open and just update the title a bit to reflect the desire. When we move minimum node versions we would certainly be happy to remove abort-controller.

@ddelgrosso1 ddelgrosso1 added type: cleanup An internal cleanup or hygiene concern. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 5, 2023
@ddelgrosso1 ddelgrosso1 changed the title Consideration of removing an unnecessary dependency deps: Consideration of removing an unnecessary dependency (abort-controller) Jun 5, 2023
@ddelgrosso1 ddelgrosso1 changed the title deps: Consideration of removing an unnecessary dependency (abort-controller) cleanup(deps): Consideration of removing an unnecessary dependency (abort-controller) Jun 12, 2023
@ddelgrosso1 ddelgrosso1 added the next major: breaking change this is a change that we should wait to bundle into the next major version label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SandZn @ddelgrosso1