Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check that err.message is a string before attempting indexOf #2173

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: check that err.message is a string before attempting indexOf #2173

merged 1 commit into from
Mar 30, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2171 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners March 28, 2023 20:08
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 28, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2023
@ddelgrosso1 ddelgrosso1 merged commit 130818d into googleapis:main Mar 30, 2023
@ddelgrosso1 ddelgrosso1 deleted the auth-no-message branch March 30, 2023 13:22
@release-please release-please bot mentioned this pull request Mar 30, 2023
Merged
@WontonSam WontonSam mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: err.message.indexOf is not a function
2 participants
@ddelgrosso1 @tritone