Skip to content

Conversation

@uulwake
Copy link
Contributor

@uulwake uulwake commented May 19, 2022

I cannot run my application because I got this error message.
First Image
image

Second Image
image

After learning the codebase, I found a bug from this PR 3 days ago #1920.
We should move uuid from devDependencies to dependencies because we are using it in prod.

@uulwake uulwake requested review from a team as code owners May 19, 2022 13:44
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 19, 2022
@google-cla
Copy link

google-cla bot commented May 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 19, 2022
@ddelgrosso1
Copy link
Contributor

Hi @uulwake can you follow the link and sign / agree to the CLA? Also can you amend the commit message to read fix: module_not found uuid. Once that is done we can get this merged. Thanks!

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 19, 2022
@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented May 19, 2022

My mistake I see the commit message is correct. Please just agree / sign the CLA.

@ddelgrosso1 ddelgrosso1 changed the title Fix MODULE_NOT_FOUND uuid fix(chore): MODULE_NOT_FOUND uuid May 19, 2022
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2022
@ddelgrosso1 ddelgrosso1 merged commit 0ff5aa3 into googleapis:main May 19, 2022
@ddelgrosso1
Copy link
Contributor

Thank you for the contribution!

@uulwake uulwake deleted the fix-uuid-module-not-found branch May 19, 2022 15:15
@uulwake
Copy link
Contributor Author

uulwake commented May 19, 2022

@ddelgrosso1
You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants