Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): Remove extend dependency #1908

Closed
danielbankhead opened this issue May 5, 2022 · 2 comments · Fixed by #2204
Closed

refactor(deps): Remove extend dependency #1908

danielbankhead opened this issue May 5, 2022 · 2 comments · Fixed by #2204
Assignees
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

Remove extend & @types/extend dependencies in favor of native, standardized dependencies.

@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 5, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 5, 2022
@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented Aug 2, 2022

There are several places in the code that we utilize the deep option to extend (example here). While the shallow cases could be replaced by Object.assign the deep cases would require us to either roll our own recursive option, leave extend in place, or remove in favor or something like lodash.

@danielbankhead
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants