fix: Remove DocumentReference from cursor #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: s
ehsannas
approved these changes
Oct 2, 2023
milaGGL
added
kokoro:run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursors accepts DocumentSnapshot or field values. https://googleapis.dev/nodejs/firestore/latest/CollectionReference.html#startAt
When field values are passed in to a cursor, it must followed by orderBy clauses of a 1:1 mapping relationship. But, if DocumentSnapshot is used, orderBy clauses are implicitly added by SDK on behalf of the client.
This PR fixes the problem that DocumentReference is given the same special treatment that DocumentSnapshot is receiving, but it does not provide field values like DocumentSnapshot does, which leads to query failure/ incorrect result.