Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Wrong name for entryGroupPath() in version 1.5.1 #79

Closed
ricardolsmendes opened this issue Dec 20, 2019 · 4 comments
Closed

Wrong name for entryGroupPath() in version 1.5.1 #79

ricardolsmendes opened this issue Dec 20, 2019 · 4 comments
Assignees
@alexander-fenster
Labels
api: datacatalog Issues related to the googleapis/nodejs-datacatalog API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ricardolsmendes
Copy link

Version 1.5.1 shipped with the method entrygroupPath() instead of entryGroupPath(), as it used to be in previous versions. This change breaks existing code.

Environment details

  • OS: macOS Catalina
  • Node.js version: v13.3.0
  • npm version: 6.13.4
  • @google-cloud/datacatalog version: 1.5.1

Steps to reproduce

  1. git clone https://github.com/GoogleCloudPlatform/nodejs-docs-samples
  2. cd datacatalog/cloud-client
  3. npm install
  4. npm test
@ricardolsmendes
Copy link
Author

@alexander-fenster

@alexander-fenster
Copy link
Contributor

That's sad :( We'll think and try to figure out what can be done here.

@alexander-fenster alexander-fenster self-assigned this Dec 21, 2019
@alexander-fenster alexander-fenster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 21, 2019
@alexander-fenster alexander-fenster mentioned this issue Dec 21, 2019
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Dec 26, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 5, 2020
@ricardolsmendes ricardolsmendes mentioned this issue Jan 8, 2020
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 10, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 20, 2020
@google-cloud-label-sync google-cloud-label-sync bot added the api: datacatalog Issues related to the googleapis/nodejs-datacatalog API. label Jan 30, 2020
@alexander-fenster
Copy link
Contributor

This is now fixed! https://github.com/googleapis/nodejs-datacatalog/blob/master/src/v1beta1/data_catalog_client.ts#L2685

@ricardolsmendes
Copy link
Author

Cool! I'm waiting for the new version to be published so I'll run the system tests again.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexander-fenster alexander-fenster

Labels
api: datacatalog Issues related to the googleapis/nodejs-datacatalog API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexander-fenster @ricardolsmendes @yoshi-automation