Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify query methods to return just QueryRowsResponse #1400

Open
alvarowolfx opened this issue Aug 30, 2024 · 0 comments
Open

Simplify query methods to return just QueryRowsResponse #1400

alvarowolfx opened this issue Aug 30, 2024 · 0 comments
Assignees
@alvarowolfx
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alvarowolfx
Copy link
Contributor

For the type returned by the query method, for historical/backward compatibility reasons, the method signature shows that it can return both a Promise<QueryRowsResponse> (which has 3 positional parameters) or Promise<SimpleQueryRowsResponse (which has only 2).

Ideally we should only return QueryRowsResponse and remove any reference to SimpleQueryRowsResponse. This is going to be a breaking change, so we should schedule this for the next major node upgrade release.
@alvarowolfx alvarowolfx added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 30, 2024
@alvarowolfx alvarowolfx self-assigned this Aug 30, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Aug 30, 2024
@alvarowolfx alvarowolfx added the next major: breaking change this is a change that we should wait to bundle into the next major version label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarowolfx alvarowolfx

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alvarowolfx