-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change startIndex option type from string to number #1351
Conversation
startIndex should be an 0-indexed integer. But as it is was expecting a string which is incorrect and caused a lot of confusion, preventing compilation and requiring odd workarounds.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
this file should not be manually modified, as it is generated from the Discovery doc (with the command |
@alvarowolfx Ah got it, I will close this PR then but the issue remains open. I am happy to contribute a solution, but not sure where to find/update the relevant Discovery Doc definition. If you want to point me to it I can attempt. Or someone who knows the procedure might be better suited to make the quick fix. |
the Discovery document represents the backend/API definition, so it can only be changed by the service side itself. In this case, would be a change on the BigQuery backend. What can be done is to change the generated code to take into consideration the |
Another thing to consider is that the |
startIndex should be an 0-indexed integer. But as it is was expecting a string which is incorrect and caused a lot of confusion, preventing compilation and requiring odd workarounds.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1350 🙏