Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update owlbot yaml to match generated folder structure #2620

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: update owlbot yaml to match generated folder structure #2620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/.OwlBot-hermetic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ deep-copy-regex:
dest: "/owl-bot-staging/v2/grpc-google-cloud-storage-v2/src"
- source: "/google/storage/v2/.*-java/gapic-google-.*/src"
dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src"
- source: "/google/storage/v2/google-cloud-storage-v2-java/gapic-google-cloud-storage-v2-java/src/main/java/com/google/storage/v2/gapic_metadata.json"
- source: "/google/storage/v2/.*-java/gapic-google-.*/src/main/java/com/google/storage/v2/gapic_metadata.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why gapic_metadata.json is not included by the previous entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from a commit back in January 2dec9d4

It makes sense that the previous entry should bring it, but it doesn't

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry means to move gapic_metadata.json from main/java to main/resources.

Looks like a library specific post processing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you. I oversaw this is a copy query into resources.

dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src/main/resources/com/google/storage/v2/gapic_metadata.json"
- source: "/google/storage/control/v2/.*-java/proto-google-.*/src"
dest: "/owl-bot-staging/v2/proto-google-cloud-storage-control-v2/src"
- source: "/google/storage/control/v2/.*-java/grpc-google-.*/src"
dest: "/owl-bot-staging/v2/grpc-google-cloud-storage-control-v2/src"
- source: "/google/storage/control/v2/.*-java/gapic-google-.*/src"
dest: "/owl-bot-staging/v2/google-cloud-storage-control/src"
- source: "/google/storage/control/v2/.*-java/gapic-google-cloud-storage-control-v2-java/src/main/java/com/google/storage/control/v2/gapic_metadata.json"
- source: "/google/storage/control/v2/.*-java/gapic-google-.*/src/main/java/com/google/storage/control/v2/gapic_metadata.json"
dest: "/owl-bot-staging/v2/google-cloud-storage-control/src/main/resources/com/google/storage/control/v2/gapic_metadata.json"
Loading