-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update owlbot yaml to match generated folder structure #2620
Conversation
@@ -31,13 +31,13 @@ deep-copy-regex: | |||
dest: "/owl-bot-staging/v2/grpc-google-cloud-storage-v2/src" | |||
- source: "/google/storage/v2/.*-java/gapic-google-.*/src" | |||
dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src" | |||
- source: "/google/storage/v2/google-cloud-storage-v2-java/gapic-google-cloud-storage-v2-java/src/main/java/com/google/storage/v2/gapic_metadata.json" | |||
- source: "/google/storage/v2/.*-java/gapic-google-.*/src/main/java/com/google/storage/v2/gapic_metadata.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why gapic_metadata.json
is not included by the previous entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from a commit back in January 2dec9d4
It makes sense that the previous entry should bring it, but it doesn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry means to move gapic_metadata.json
from main/java
to main/resources
.
Looks like a library specific post processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you. I oversaw this is a copy query into resources.
Fixes https://github.com/googleapis/java-storage/pull/2619/files#r1662929781