Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetIamPolicy incorrectly uses BucketSourceOptions when not all fields are applicable #1074

Open
frankyn opened this issue Oct 5, 2021 · 0 comments
Open

SetIamPolicy incorrectly uses BucketSourceOptions when not all fields are applicable #1074

frankyn opened this issue Oct 5, 2021 · 0 comments
Labels
api: storage Issues related to the googleapis/java-storage API. type: cleanup An internal cleanup or hygiene concern.
Milestone
Retry Conformance...

Comments

@frankyn
Copy link
Member

frankyn commented Oct 5, 2021

storage.SetIamPolicy incorrectly uses BucketSourceOptions when not all fields are applicable

We should deprecate this method signature and create a separate implementation BucketIamOptions which maps back to actual fields expected by the API: https://cloud.google.com/storage/docs/json_api/v1/buckets/setIamPolicy
@frankyn frankyn added the type: cleanup An internal cleanup or hygiene concern. label Oct 5, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Oct 5, 2021
@frankyn frankyn assigned frankyn and unassigned frankyn Oct 5, 2021
@BenWhitehead BenWhitehead added this to the Retry Conformance Project milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
Retry Conformance Project
Development

No branches or pull requests
2 participants
@BenWhitehead @frankyn