Skip to content

Commit 54c1951

Browse files
committed
rebase: rebase on current master
1 parent f6e2c9e commit 54c1951

File tree

10 files changed

+23
-16
lines changed

10 files changed

+23
-16
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
import com.google.spanner.v1.TransactionOptions;
5050
import com.google.spanner.v1.TransactionSelector;
5151
import io.opencensus.trace.Span;
52+
import io.opencensus.trace.Tracing;
5253
import java.util.Map;
5354
import java.util.concurrent.atomic.AtomicLong;
5455
import javax.annotation.Nullable;
@@ -67,6 +68,7 @@ abstract static class Builder<B extends Builder<?, T>, T extends AbstractReadCon
6768
private Span span = Tracing.getTracer().getCurrentSpan();
6869
private int defaultPrefetchChunks = SpannerOptions.Builder.DEFAULT_PREFETCH_CHUNKS;
6970
private QueryOptions defaultQueryOptions = SpannerOptions.Builder.DEFAULT_QUERY_OPTIONS;
71+
private ExecutorProvider executorProvider;
7072

7173
Builder() {}
7274

@@ -100,6 +102,11 @@ B setDefaultQueryOptions(QueryOptions defaultQueryOptions) {
100102
return self();
101103
}
102104

105+
B setExecutorProvider(ExecutorProvider executorProvider) {
106+
this.executorProvider = executorProvider;
107+
return self();
108+
}
109+
103110
abstract T build();
104111
}
105112

@@ -391,6 +398,7 @@ void initTransaction() {
391398
this.defaultPrefetchChunks = builder.defaultPrefetchChunks;
392399
this.defaultQueryOptions = builder.defaultQueryOptions;
393400
this.span = builder.span;
401+
this.executorProvider = builder.executorProvider;
394402
}
395403

396404
@Override

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BatchClientImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public BatchReadOnlyTransaction batchReadOnlyTransaction(TimestampBound bound) {
5252
.setTimestampBound(bound)
5353
.setDefaultQueryOptions(
5454
sessionClient.getSpanner().getDefaultQueryOptions(sessionClient.getDatabaseId()))
55+
.setExecutorProvider(sessionClient.getSpanner().getAsyncExecutorProvider())
5556
.setDefaultPrefetchChunks(sessionClient.getSpanner().getDefaultPrefetchChunks()),
5657
checkNotNull(bound));
5758
}
@@ -68,6 +69,7 @@ public BatchReadOnlyTransaction batchReadOnlyTransaction(BatchTransactionId batc
6869
.setTimestamp(batchTransactionId.getTimestamp())
6970
.setDefaultQueryOptions(
7071
sessionClient.getSpanner().getDefaultQueryOptions(sessionClient.getDatabaseId()))
72+
.setExecutorProvider(sessionClient.getSpanner().getAsyncExecutorProvider())
7173
.setDefaultPrefetchChunks(sessionClient.getSpanner().getDefaultPrefetchChunks()),
7274
batchTransactionId);
7375
}

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.google.cloud.spanner.AbstractReadContext.SingleReadContext;
2626
import com.google.cloud.spanner.AbstractReadContext.SingleUseReadOnlyTransaction;
2727
import com.google.cloud.spanner.SessionClient.SessionId;
28-
import com.google.cloud.spanner.TransactionRunner.TransactionCallable;
2928
import com.google.cloud.spanner.TransactionRunnerImpl.TransactionContextImpl;
3029
import com.google.cloud.spanner.spi.v1.SpannerRpc;
3130
import com.google.common.collect.Lists;
@@ -177,6 +176,8 @@ public ReadContext singleUse(TimestampBound bound) {
177176
.setRpc(spanner.getRpc())
178177
.setDefaultQueryOptions(spanner.getDefaultQueryOptions(databaseId))
179178
.setDefaultPrefetchChunks(spanner.getDefaultPrefetchChunks())
179+
.setSpan(currentSpan)
180+
.setExecutorProvider(spanner.getAsyncExecutorProvider())
180181
.build());
181182
}
182183

@@ -194,6 +195,8 @@ public ReadOnlyTransaction singleUseReadOnlyTransaction(TimestampBound bound) {
194195
.setRpc(spanner.getRpc())
195196
.setDefaultQueryOptions(spanner.getDefaultQueryOptions(databaseId))
196197
.setDefaultPrefetchChunks(spanner.getDefaultPrefetchChunks())
198+
.setSpan(currentSpan)
199+
.setExecutorProvider(spanner.getAsyncExecutorProvider())
197200
.buildSingleUseReadOnlyTransaction());
198201
}
199202

@@ -211,6 +214,8 @@ public ReadOnlyTransaction readOnlyTransaction(TimestampBound bound) {
211214
.setRpc(spanner.getRpc())
212215
.setDefaultQueryOptions(spanner.getDefaultQueryOptions(databaseId))
213216
.setDefaultPrefetchChunks(spanner.getDefaultPrefetchChunks())
217+
.setSpan(currentSpan)
218+
.setExecutorProvider(spanner.getAsyncExecutorProvider())
214219
.build());
215220
}
216221

@@ -281,6 +286,7 @@ TransactionContextImpl newTransaction() {
281286
.setDefaultQueryOptions(spanner.getDefaultQueryOptions(databaseId))
282287
.setDefaultPrefetchChunks(spanner.getDefaultPrefetchChunks())
283288
.setSpan(currentSpan)
289+
.setExecutorProvider(spanner.getAsyncExecutorProvider())
284290
.build();
285291
}
286292

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
import com.google.common.base.Preconditions;
4444
import com.google.common.collect.ImmutableMap;
4545
import com.google.common.collect.ImmutableSet;
46-
import com.google.spanner.v1.ExecuteSqlRequest.QueryOptions;
4746
import com.google.common.util.concurrent.ThreadFactoryBuilder;
47+
import com.google.spanner.v1.ExecuteSqlRequest.QueryOptions;
4848
import io.grpc.CallCredentials;
4949
import io.grpc.ManagedChannelBuilder;
5050
import java.io.IOException;
@@ -54,11 +54,11 @@
5454
import java.util.Map;
5555
import java.util.Map.Entry;
5656
import java.util.Set;
57-
import javax.annotation.Nonnull;
5857
import java.util.concurrent.ScheduledThreadPoolExecutor;
5958
import java.util.concurrent.ThreadFactory;
6059
import java.util.concurrent.TimeUnit;
6160
import java.util.concurrent.atomic.AtomicInteger;
61+
import javax.annotation.Nonnull;
6262
import org.threeten.bp.Duration;
6363

6464
/** Options for the Cloud Spanner service. */

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import com.google.api.core.ApiFunction;
2525
import com.google.api.core.ApiFuture;
2626
import com.google.api.core.ApiFutures;
27-
import com.google.api.gax.core.ExecutorProvider;
2827
import com.google.cloud.Timestamp;
2928
import com.google.cloud.spanner.Options.QueryOption;
3029
import com.google.cloud.spanner.Options.ReadOption;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractReadContextTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.mockito.Mockito.mock;
2121
import static org.mockito.Mockito.when;
2222

23+
import com.google.api.gax.core.ExecutorProvider;
2324
import com.google.cloud.spanner.spi.v1.SpannerRpc;
2425
import com.google.spanner.v1.ExecuteSqlRequest;
2526
import com.google.spanner.v1.ExecuteSqlRequest.QueryMode;
@@ -80,6 +81,7 @@ public void setup() {
8081
.setSession(session)
8182
.setRpc(mock(SpannerRpc.class))
8283
.setDefaultQueryOptions(defaultQueryOptions)
84+
.setExecutorProvider(mock(ExecutorProvider.class))
8385
.build();
8486
}
8587

google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,19 @@
3636
import com.google.cloud.spanner.ReadContext.QueryAnalyzeMode;
3737
import com.google.cloud.spanner.TransactionRunner.TransactionCallable;
3838
import com.google.common.base.Stopwatch;
39-
import com.google.protobuf.AbstractMessage;
4039
import com.google.common.util.concurrent.SettableFuture;
41-
import com.google.protobuf.ListValue;
40+
import com.google.protobuf.AbstractMessage;
4241
import com.google.spanner.v1.ExecuteSqlRequest;
4342
import com.google.spanner.v1.ExecuteSqlRequest.QueryMode;
4443
import com.google.spanner.v1.ExecuteSqlRequest.QueryOptions;
45-
import com.google.spanner.v1.ResultSetMetadata;
46-
import com.google.spanner.v1.StructType;
47-
import com.google.spanner.v1.StructType.Field;
48-
import com.google.spanner.v1.TypeCode;
4944
import io.grpc.Server;
5045
import io.grpc.Status;
5146
import io.grpc.StatusRuntimeException;
5247
import io.grpc.inprocess.InProcessServerBuilder;
5348
import java.io.IOException;
54-
import java.util.List;
5549
import java.util.ArrayList;
5650
import java.util.Arrays;
57-
import java.util.concurrent.CountDownLatch;
51+
import java.util.List;
5852
import java.util.concurrent.ExecutionException;
5953
import java.util.concurrent.ExecutorService;
6054
import java.util.concurrent.Executors;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535

3636
import com.google.api.core.ApiFuture;
3737
import com.google.api.core.ApiFutures;
38-
import com.google.api.gax.core.ExecutorProvider;
3938
import com.google.cloud.Timestamp;
4039
import com.google.cloud.spanner.MetricRegistryTestUtils.FakeMetricRegistry;
4140
import com.google.cloud.spanner.MetricRegistryTestUtils.MetricsRecord;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/TransactionContextImplTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919
import static org.mockito.Mockito.mock;
2020
import static org.mockito.Mockito.when;
2121

22-
import com.google.api.gax.core.ExecutorProvider;
2322
import com.google.cloud.spanner.TransactionRunnerImpl.TransactionContextImpl;
2423
import com.google.cloud.spanner.spi.v1.SpannerRpc;
2524
import com.google.protobuf.ByteString;
2625
import com.google.rpc.Code;
2726
import com.google.rpc.Status;
2827
import com.google.spanner.v1.ExecuteBatchDmlRequest;
2928
import com.google.spanner.v1.ExecuteBatchDmlResponse;
30-
import io.opencensus.trace.Span;
3129
import java.util.Arrays;
3230
import org.junit.Test;
3331
import org.junit.runner.RunWith;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/TransactionRunnerImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import static org.mockito.Mockito.when;
2626

2727
import com.google.api.core.ApiFutures;
28-
import com.google.api.gax.core.ExecutorProvider;
2928
import com.google.cloud.grpc.GrpcTransportOptions;
3029
import com.google.cloud.grpc.GrpcTransportOptions.ExecutorFactory;
3130
import com.google.cloud.spanner.SessionClient.SessionId;

0 commit comments

Comments
 (0)