From 9a0a2ba978eeec01a5b4d4792d55d1f0f4d0b54f Mon Sep 17 00:00:00 2001 From: Simon Scholz Date: Sat, 25 Feb 2023 23:11:57 +0100 Subject: [PATCH] feat: Improve TopicName.parse ValidationException message The formattedString param's value should also be part of the ValidationException message --- .../src/main/java/com/google/pubsub/v1/TopicName.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proto-google-cloud-pubsub-v1/src/main/java/com/google/pubsub/v1/TopicName.java b/proto-google-cloud-pubsub-v1/src/main/java/com/google/pubsub/v1/TopicName.java index 4d16d44af..d9212d400 100644 --- a/proto-google-cloud-pubsub-v1/src/main/java/com/google/pubsub/v1/TopicName.java +++ b/proto-google-cloud-pubsub-v1/src/main/java/com/google/pubsub/v1/TopicName.java @@ -118,7 +118,8 @@ public static TopicName parse(String formattedString) { } else if (DELETED_TOPIC.equals(formattedString)) { return new TopicName("_deleted-topic_"); } - throw new ValidationException("TopicName.parse: formattedString not in valid format"); + throw new ValidationException( + "TopicName.parse: formattedString (%s) not in valid format", formattedString); } public static List parseList(List formattedStrings) {