Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appender default flushlevel is inconsistent with java-logging client's default #1328

Open
burkedavison opened this issue May 29, 2024 · 1 comment
Assignees
Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@burkedavison
Copy link
Member

The java-logging library updated its flushlevel default to OFF in Dec 2018 due to the performance cost of flushing on the same thread as the application.

However, the java-logging-logback appender was implemented in May 2017 to default to ERROR, and continues to default to ERROR.

( Add'l context: This came to our attention with a request to make Spring Cloud GCP's helper-implementation of a logback appender match the base library's default. See GoogleCloudPlatform/spring-cloud-gcp#2906 for discussion. )

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label May 29, 2024
@cindy-peng cindy-peng added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 26, 2024
@cindy-peng
Copy link
Contributor

Good catch! Thanks for reporting @burkedavison! We will work on a fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

No branches or pull requests

2 participants