Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flakey ITDatastoreTest#testSkippedResults #46

Merged
merged 2 commits into from
Feb 14, 2020
Merged

fix: flakey ITDatastoreTest#testSkippedResults #46

merged 2 commits into from
Feb 14, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Feb 14, 2020

Fixes #18

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2020
@codecov
Copy link

codecov bot commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #46 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     59.44%   59.44%           
  Complexity      384      384           
=========================================
  Files            46       46           
  Lines          2286     2286           
  Branches        251      251           
=========================================
  Hits           1359     1359           
  Misses          820      820           
  Partials        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b92998...bb55c02. Read the comment docs.

@athakor athakor changed the title fix: flakey testSkippedResults test fix: flakey ITDatastoreTest#testSkippedResults Feb 14, 2020
@BenWhitehead BenWhitehead merged commit 3035ef2 into googleapis:master Feb 14, 2020
@yoshi-automation yoshi-automation mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datastore IT test is flakey
3 participants
@athakor @BenWhitehead @googlebot