Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): change update entity sample to use transaction #1633

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

cindy-peng
Copy link
Contributor

@cindy-peng cindy-peng commented Oct 24, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
Java samples do not use transaction but rest of the languages do

Link to Example:

https://cloud.google.com/datastore/docs/concepts/entities#update_an_entity

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Oct 24, 2024
@cindy-peng cindy-peng merged commit c44f17a into main Oct 24, 2024
22 checks passed
@cindy-peng cindy-peng deleted the cindy/docfixit branch October 24, 2024 20:59
@cindy-peng cindy-peng assigned cindy-peng and unassigned Mukamik Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants