Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for MergeToCell API #2258

Merged
merged 16 commits into from
Jul 24, 2024
Merged

feat: Add support for MergeToCell API #2258

merged 16 commits into from
Jul 24, 2024

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Jun 11, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 11, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 11, 2024
steveniemitz
steveniemitz reviewed Jul 22, 2024
View reviewed changes
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java Outdated
"agg-family",
"qual2",
1000,
Base64.getEncoder().encode(BigInteger.valueOf(1234).toByteArray()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this the "real" way instead? I worry about people looking at these tests for examples and doing it wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

steveniemitz
steveniemitz reviewed Jul 22, 2024
View reviewed changes
samples/snippets/src/main/java/com/example/bigtable/WriteAggregate.java Outdated
.mergeToCell(COUNT_COLUMN_FAMILY_NAME,
"views",
hourlyBucketMicros,
Base64.getEncoder().encode(BigInteger.valueOf(1).toByteArray()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, this wouldn't actually work in real life

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ron-gal ron-gal marked this pull request as ready for review July 22, 2024 18:34
@ron-gal ron-gal requested review from a team as code owners July 22, 2024 18:34
@steveniemitz
Copy link
Contributor

/gcbrun

2 similar comments
@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz steveniemitz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@steveniemitz steveniemitz added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@steveniemitz
Copy link
Contributor

/gcbrun

@ron-gal
Copy link
Contributor Author

ron-gal commented Jul 24, 2024

/gcbrun

1 similar comment
@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz steveniemitz added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz
Copy link
Contributor

/gcbrun

@steveniemitz steveniemitz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@steveniemitz steveniemitz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@steveniemitz steveniemitz added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@steveniemitz steveniemitz merged commit 191d15c into googleapis:main Jul 24, 2024
21 checks passed
@ron-gal ron-gal deleted the aggregates branch July 24, 2024 17:06
@release-please release-please bot mentioned this pull request Jul 24, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 24, 2024
@release-please
chore(main): release 2.41.0 (#2277)
664e615 
🤖 I have created a release *beep* *boop*
---


## [2.41.0](https://github.com/googleapis/java-bigtable/compare/v2.40.0...v2.41.0) (2024-07-24)


### Features

* Add MergeToCell to Mutation APIs ([#2279](https://github.com/googleapis/java-bigtable/issues/2279)) ([0ce8a2a](https://github.com/googleapis/java-bigtable/commit/0ce8a2a38703233da58208655f41f6e81e03576e))
* Add support for MergeToCell API ([#2258](https://github.com/googleapis/java-bigtable/issues/2258)) ([191d15c](https://github.com/googleapis/java-bigtable/commit/191d15c5284dbb702e11669931272877bf05f44e))
* Add support for new functions ([#2287](https://github.com/googleapis/java-bigtable/issues/2287)) ([dd6583a](https://github.com/googleapis/java-bigtable/commit/dd6583a22504385b7a1f7dc91b3bc3d2500ea0c5))
* Create new environment variable to toggle directpath scoped to cloud bigtable. ([#2261](https://github.com/googleapis/java-bigtable/issues/2261)) ([9062944](https://github.com/googleapis/java-bigtable/commit/9062944610277eb7ae77f395dc79ce94239c5bee))
* Implement ExecuteQuery API for SQL support ([#2280](https://github.com/googleapis/java-bigtable/issues/2280)) ([25218e8](https://github.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1))


### Dependencies

* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.4 ([#2282](https://github.com/googleapis/java-bigtable/issues/2282)) ([d00a9e0](https://github.com/googleapis/java-bigtable/commit/d00a9e01b2b329f3bae50f48a15692d87ad0f3bf))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@ron-gal @gcf-owl-bot @lqiu96
feat: Add support for MergeToCell API (#2258)
95d48e6 
* feat: Add support for MergeToCell API

* feat: Add support for MergeToCell API

* fix build

* fix build

* fix format

* fix build

* fix build

* fix build

* fix format

* fix test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update WriteAggregate.java

* Update WriteAggregate.java

* Update WriteAggregate.java

* Update WriteAggregate.java

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@release-please @lqiu96
chore(main): release 2.41.0 (#2277)
2ad3242 
🤖 I have created a release *beep* *boop*
---


## [2.41.0](https://github.com/googleapis/java-bigtable/compare/v2.40.0...v2.41.0) (2024-07-24)


### Features

* Add MergeToCell to Mutation APIs ([#2279](https://github.com/googleapis/java-bigtable/issues/2279)) ([0ce8a2a](https://github.com/googleapis/java-bigtable/commit/0ce8a2a38703233da58208655f41f6e81e03576e))
* Add support for MergeToCell API ([#2258](https://github.com/googleapis/java-bigtable/issues/2258)) ([191d15c](https://github.com/googleapis/java-bigtable/commit/191d15c5284dbb702e11669931272877bf05f44e))
* Add support for new functions ([#2287](https://github.com/googleapis/java-bigtable/issues/2287)) ([dd6583a](https://github.com/googleapis/java-bigtable/commit/dd6583a22504385b7a1f7dc91b3bc3d2500ea0c5))
* Create new environment variable to toggle directpath scoped to cloud bigtable. ([#2261](https://github.com/googleapis/java-bigtable/issues/2261)) ([9062944](https://github.com/googleapis/java-bigtable/commit/9062944610277eb7ae77f395dc79ce94239c5bee))
* Implement ExecuteQuery API for SQL support ([#2280](https://github.com/googleapis/java-bigtable/issues/2280)) ([25218e8](https://github.com/googleapis/java-bigtable/commit/25218e8cc46f9a51d4b6515afdb8931e574b0bb1))


### Dependencies

* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.4 ([#2282](https://github.com/googleapis/java-bigtable/issues/2282)) ([d00a9e0](https://github.com/googleapis/java-bigtable/commit/d00a9e01b2b329f3bae50f48a15692d87ad0f3bf))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveniemitz steveniemitz steveniemitz approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ron-gal @steveniemitz @yoshi-kokoro