Skip to content

Commit beb0219

Browse files
authored
chore: refactor factory class (#2081)
1 parent 043d551 commit beb0219

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,9 @@ public static ApiTracerFactory createBigtableTracerFactory(
261261
.put("app_profile", appProfileId)
262262
.build();
263263

264-
return new CompositeTracerFactory(
265-
ImmutableList.of(
266-
// Add OpenCensus Tracing
264+
ImmutableList.Builder<ApiTracerFactory> tracerFactories = ImmutableList.builder();
265+
tracerFactories
266+
.add(
267267
new OpencensusTracerFactory(
268268
ImmutableMap.<String, String>builder()
269269
// Annotate traces with the same tags as metrics
@@ -274,12 +274,14 @@ public static ApiTracerFactory createBigtableTracerFactory(
274274
.put("gax", GaxGrpcProperties.getGaxGrpcVersion())
275275
.put("grpc", GaxGrpcProperties.getGrpcVersion())
276276
.put("gapic", Version.VERSION)
277-
.build()),
278-
// Add OpenCensus Metrics
279-
MetricsTracerFactory.create(tagger, stats, attributes),
280-
BuiltinMetricsTracerFactory.create(builtinAttributes),
281-
// Add user configured tracer
282-
settings.getTracerFactory()));
277+
.build()))
278+
// Add OpenCensus Metrics
279+
.add(MetricsTracerFactory.create(tagger, stats, attributes))
280+
.add(BuiltinMetricsTracerFactory.create(builtinAttributes))
281+
// Add user configured tracer
282+
.add(settings.getTracerFactory());
283+
284+
return new CompositeTracerFactory(tracerFactories.build());
283285
}
284286

285287
private static void patchCredentials(EnhancedBigtableStubSettings.Builder settings)

0 commit comments

Comments
 (0)