fix: add stream name to every request when connection is created during multiplexing #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be added in the next PR
will be added in the next PR
product-auto-label
bot
added
size: m
yirutang
reviewed
Oct 8, 2024
| @@ -279,26 +275,20 @@ public void testAppendInSameStream_switchSchema() throws Exception { | |||
|
|
|||
| // We will get the request as the pattern of: | |||
| // (writer_stream: t1, schema: schema1) | |||
| // (writer_stream: _, schema: _) | |||
| // (writer_stream: t1, schema: _) | |||
There was a problem hiding this comment.
How do we know we are multiplexed before the actual switch?
There was a problem hiding this comment.
the connection would be created via connectionPool
yirutang
approved these changes
Oct 8, 2024
during multiplexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: this is not required, but we may want to add this as extra safety to make sure every request is landed onto the correct table.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.