Skip to content

chore: grant write access to @googleapis/cloud-java-team-teamsync #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 2 commits into from
Nov 14, 2025
Merged

chore: grant write access to @googleapis/cloud-java-team-teamsync #3999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9142cf6
chore: grant write access to @googleapis/cloud-java-team-teamsync
diegomarquezp Nov 13, 2025
9e3f09f
Update CODEOWNERS to simplify ownership rules
diegomarquezp Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

# The @googleapis/api-bigquery is the default owner for changes in this repo
* @googleapis/yoshi-java @googleapis/api-bigquery
* @googleapis/cloud-java-team-teamsync @googleapis/api-bigquery

# for handwritten libraries, keep codeowner_team in .repo-metadata.json as owner
**/*.java @googleapis/api-bigquery
**/*.java @googleapis/cloud-java-team-teamsync @googleapis/api-bigquery
Copy link

@gemini-code-assist gemini-code-assist bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line has become redundant. The owners specified here are identical to the default owners defined on line 8. Since rules in CODEOWNERS are processed from top to bottom with the last matching pattern taking precedence, and * on line 8 already covers all files, this specific rule for **/*.java with the same owners is unnecessary. You can remove this line to simplify the file.

Copy link
Contributor

@blakeli0 blakeli0 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomarquezp This is a valid review, do you mind removing the redundant configuration?

Copy link
Contributor Author

@diegomarquezp diegomarquezp Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done



# The java-samples-reviewers team is the default owner for samples changes
samples/**/*.java @googleapis/java-samples-reviewers
samples/**/*.java @googleapis/cloud-java-team-teamsync @googleapis/java-samples-reviewers

# Generated snippets should not be owned by samples reviewers
samples/snippets/generated/ @googleapis/yoshi-java
samples/snippets/generated/ @googleapis/cloud-java-team-teamsync @googleapis/yoshi-java