Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE for executeSelect nonFast path with empty result #3445

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Aug 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3441 ☕️

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Aug 21, 2024
@PhongChuong PhongChuong marked this pull request as ready for review August 21, 2024 19:45
@PhongChuong PhongChuong requested a review from a team as a code owner August 21, 2024 19:45
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2024
@PhongChuong PhongChuong merged commit d0d758a into main Aug 22, 2024
20 checks passed
@PhongChuong PhongChuong deleted the i3441 branch August 22, 2024 16:48
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
* fix: NPE for executeSelect nonFast path with empty result

* remove commented out extraneous code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery connection api with fast path disabled throws NPE for queries that return 0 rows
2 participants