Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests break mvn verify (without additional, undocumented setup) #28

Closed
elharo opened this issue Dec 12, 2019 · 5 comments
Closed
Assignees
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. semver: patch A minor bug fix or small change. type: process A process-related concern. May include testing, release, or the like.

Comments

@elharo
Copy link
Contributor

elharo commented Dec 12, 2019

With the inclusion of the samples into the repo, a simple clone and mvn verify no longer works. Undoubtedly there's some extra setup required. Ideally there shouldn;t be, but if this is mandatory then the needed steps need to be clearly documented in the relevant files in the repo.

[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.002 s <<< FAILURE! - in com.google.cloud.bigquery.it.ITBigQueryTest
[ERROR] com.google.cloud.bigquery.it.ITBigQueryTest  Time elapsed: 1.001 s  <<< ERROR!
com.google.cloud.storage.StorageException: 401 Unauthorized
	at com.google.cloud.bigquery.it.ITBigQueryTest.beforeClass(ITBigQueryTest.java:290)
Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException: 401 Unauthorized
	at com.google.cloud.bigquery.it.ITBigQueryTest.beforeClass(ITBigQueryTest.java:290)

[ERROR] com.google.cloud.bigquery.it.ITBigQueryTest  Time elapsed: 1.002 s  <<< ERROR!
com.google.cloud.bigquery.BigQueryException: Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.
	at com.google.cloud.bigquery.it.ITBigQueryTest.afterClass(ITBigQueryTest.java:323)
Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException: 
401 Unauthorized
{
  "code" : 401,
  "errors" : [ {
    "domain" : "global",
    "location" : "Authorization",
    "locationType" : "header",
    "message" : "Login Required.",
    "reason" : "required"
  } ],
  "message" : "Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",
  "status" : "UNAUTHENTICATED"
}
	at com.google.cloud.bigquery.it.ITBigQueryTest.afterClass(ITBigQueryTest.java:323)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR] com.google.cloud.bigquery.it.ITBigQueryTest.com.google.cloud.bigquery.it.ITBigQueryTest
[ERROR]   Run 1: ITBigQueryTest.beforeClass:290 » Storage 401 Unauthorized
[ERROR]   Run 2: ITBigQueryTest.afterClass:323 » BigQuery Request is missing required authentic...
[INFO] 
[INFO] 
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
[INFO] 
@elharo elharo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. semver: patch A minor bug fix or small change. labels Dec 12, 2019
@stephaniewang526 stephaniewang526 self-assigned this Dec 12, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 13, 2019
@chingor13 chingor13 added type: process A process-related concern. May include testing, release, or the like. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 13, 2019
@chingor13
Copy link
Contributor

As discussed in our sync up, these ones are just the normal integration test suite. We will be changing the integration test execution to be opt-in rather than opt-out.

@chingor13 chingor13 changed the title samples break mvn verify Integration tests break mvn verify (without additional, undocumented setup) Dec 13, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Dec 13, 2019
@BenWhitehead
Copy link

A fix for this is in googleapis/java-shared-config#75

@stephaniewang526
Copy link
Contributor

29ede0f this should have fixed this issue @elharo

@BenWhitehead
Copy link

Not yet fully fixed, still need the bump on shared-config to go out.

@google-cloud-label-sync google-cloud-label-sync bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jan 29, 2020
@BenWhitehead
Copy link

Released in shared-config v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. semver: patch A minor bug fix or small change. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

5 participants