fix: animal-sniffer and clirr to a profiles #1145
Merged
+67
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/384085175#comment40 We can skip animal-sniffer-maven-plugin execution if we wrap it as a profile.
suztomo
changed the title
suztomo
commented
Jan 30, 2025
| @@ -62,18 +62,6 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <!--App Engine uses Java 7 or Java 8--> | |||
| <plugin> | |||
There was a problem hiding this comment.
The parent already defines the plugin declaration.
suztomo
commented
Jan 30, 2025
| @@ -47,18 +47,6 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <!--Set minimum version to Java 7--> | |||
| <plugin> | |||
There was a problem hiding this comment.
The parent already defines the plugin declaration.
suztomo
commented
Jan 30, 2025
| @@ -49,18 +49,6 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <!--Minimum version is Java 7 --> | |||
| <plugin> | |||
There was a problem hiding this comment.
The parent already defines the plugin declaration.
meltsufin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/384085175#comment40
We can skip animal-sniffer-maven-plugin and CLIRR plugin execution if we wrap it as a profile.