fix: deprecating the IdTokenVerifier.verify, adding verifyOrThrow as an alternative #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecating, adding IdToken.verifyOrThrow as an alternative
arithmetic1728
approved these changes
Dec 7, 2023
westarle
reviewed
Dec 18, 2023
google-oauth-client/src/main/java/com/google/api/client/auth/openidconnect/IdTokenVerifier.java
Outdated
Show resolved
Hide resolved
westarle
reviewed
Dec 18, 2023
google-oauth-client/src/main/java/com/google/api/client/auth/openidconnect/IdTokenVerifier.java
Outdated
Show resolved
Hide resolved
westarle
approved these changes
Dec 18, 2023
product-auto-label
bot
added
size: m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the interface of the IdTokenVerifier.verify method to avoid a previous breaking change that was not released yet. It also deprecates the method as it is no longer recommended to use because it can produce false-negatives if public keys for signature verification are not available.
Here we add the IdTokenVerifier.verifyOrThrow as an alternative that throws IOExceptions if any issues getting public keys.