Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default *Client name for OpenAPI is not very ergonomic #235

Open
coryan opened this issue Nov 20, 2024 · 1 comment · May be fixed by #269
Open

Default *Client name for OpenAPI is not very ergonomic #235

coryan opened this issue Nov 20, 2024 · 1 comment · May be fixed by #269
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Nov 20, 2024

The factory function for secret manager comes out as .google_cloud_secretmanager_v_1_secret_manager_service() and the class as the PascalCase version of that. Yuck.

@coryan coryan added the type: cleanup An internal cleanup or hygiene concern. label Nov 20, 2024
@coryan coryan changed the title Default *Client name for OpenAPI is not very ergonomic` Default *Client name for OpenAPI is not very ergonomic Nov 21, 2024
@codyoss
Copy link
Member

codyoss commented Nov 21, 2024

Yeah, I think we need a codec option for this if we can't programmatically come up with a good name for openAPI clients. We have this in a couple languages today as a part of the per-language service config settings.

@coryan coryan self-assigned this Nov 22, 2024
@coryan coryan linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants