Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nox isn't linting tests #4697

Closed
theacodes opened this issue Jan 4, 2018 · 4 comments
Closed

Nox isn't linting tests #4697

theacodes opened this issue Jan 4, 2018 · 4 comments
Assignees
@theacodes
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@theacodes
Copy link
Contributor

Our nox configuration is skipping flake8 linting of tests, we should fix that. :)
@theacodes theacodes added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 4, 2018
@theacodes theacodes self-assigned this Jan 4, 2018
@tseaver
Copy link
Contributor

tseaver commented Jan 8, 2018

@jonparrott Is this really either "P1" or a bug?

@theacodes theacodes added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 8, 2018
@theacodes
Copy link
Contributor Author

I'm gonna drop it to a p2 but this is definitely a bug.

@chemelnucfin
Copy link
Contributor

also refer to #3418 which I will close

@dhermes
Copy link
Contributor

dhermes commented Jan 15, 2018

@chemelnucfin Note that #3418 also says pylint should be turned back on (it is on, but doesn't cause test failures).

@theacodes theacodes mentioned this issue Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theacodes theacodes

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tseaver @theacodes @dhermes @chemelnucfin