Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pycodestyle update causing our lint to fail. #2974

Closed
daspecster opened this issue Jan 30, 2017 · 6 comments
Closed

Pycodestyle update causing our lint to fail. #2974

daspecster opened this issue Jan 30, 2017 · 6 comments
Assignees
@daspecster
Labels
testing

Comments

@daspecster
Copy link
Contributor

daspecster commented Jan 30, 2017 •
edited
Loading

From what I can tell, there are three new errors that pycodestyle is finding.

E306: expected 1 blank line before a nested definition, found 0
E123: closing bracket does not match indentation of opening bracket's line
E722: do not use bare except

See: #2973
@daspecster daspecster self-assigned this Jan 30, 2017
@daspecster daspecster mentioned this issue Jan 30, 2017
Merged
@dhermes
Copy link
Contributor

dhermes commented Jan 30, 2017

E123 seems legit

@daspecster
Copy link
Contributor Author

Yeah, I updated the PR to just fix the E123 errors.

@dhermes
Copy link
Contributor

dhermes commented Jan 30, 2017

I filed PyCQA/pycodestyle#621

@dhermes
Copy link
Contributor

dhermes commented Jan 31, 2017

They fixed it in 2.3.1

@dhermes
Copy link
Contributor

dhermes commented Jan 31, 2017

@daspecster I should've been more specific, they fixed the E306 false positives. We still have the E722 and maybe the E123 issues to deal with

@daspecster
Copy link
Contributor Author

Yeah I saw, maybe closed this too soon, but the rest are resolved in #2973 either way. I have an update to remove the ignore for E306 then it should be good IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daspecster daspecster

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daspecster @dhermes