feat: add exponential backoff to ResumableStream #7664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
force-pushed
the
add-retry-delay-for-bigtable-resumable-stream
branch
from
e62b520
to
01629bc
Compare
bshaffer
commented
Sep 11, 2024
igorbernstein2
requested changes
Sep 11, 2024
Bigtable/src/ResumableStream.php
Outdated
| @@ -116,6 +121,17 @@ public function __construct( | |||
| $this->callOptions['retrySettings'] = [ | |||
| 'retriesEnabled' => false | |||
| ]; | |||
|
|
|||
| $this->delayFunction = function (int $backoffCount) { | |||
There was a problem hiding this comment.
why does this need to be closure?
There was a problem hiding this comment.
It's a closure so that we can test its accuracy in the test (see this line).
There was a problem hiding this comment.
I think it would be better to use the mock framework to create a spy for this method:
prophesize(
There was a problem hiding this comment.
AFAIK, It's not possible to do what you're asking with Prophecy.
You're asking to mock a method in ResumableStream, but we are not mocking the ResumableStream class, and partial mocks are not supported in Prophecy.
igorbernstein2
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... also, ensure the exponential delay is reset when we receive a successful row