Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint rules to prefer single quotes #2915

Closed
JustinBeckwith opened this issue Apr 3, 2019 · 3 comments · Fixed by google/gts#475
Closed

update eslint rules to prefer single quotes #2915

JustinBeckwith opened this issue Apr 3, 2019 · 3 comments · Fixed by google/gts#475
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@JustinBeckwith
Copy link
Contributor

I was reading a bit of PR feedback over here, where the developer used backticks over single quotes, when not strictly necessary:
https://github.com/googleapis/nodejs-translate/pull/234/files#r271541085

If this is our story (as I think it should be), we should update our default eslint rules to enforce this via the linter:
https://eslint.org/docs/rules/quotes

@bcoe
Copy link
Contributor

bcoe commented Jan 30, 2020

@JustinBeckwith can we address this with google/gts#421

@JustinBeckwith
Copy link
Contributor Author

Of course!

@bcoe
Copy link
Contributor

bcoe commented Mar 31, 2020

Published in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants