Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix routing header for writes #8159

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jun 21, 2023

This fixes several integration tests that were broken since GCS started enforcing new formatting. Only writes are affected; for other calls, the GAPIC handles the routing annotation.

Fixes #8142
Fixes #8143
Fixes #8144
Fixes #8145
Fixes #8149

This fixes several integration tests that were broken since
GCS started enforcing new formatting. Only writes are affected;
for other calls, the GAPIC handles the routing annotation.

Fixes googleapis#8142
Fixes googleapis#8143
Fixes googleapis#8144
Fixes googleapis#8145
Fixes googleapis#8149
@tritone tritone requested review from a team as code owners June 21, 2023 02:58
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Jun 21, 2023
@tritone tritone merged commit 42a59f5 into googleapis:main Jun 21, 2023
@tritone tritone deleted the fix-routing-header branch June 21, 2023 18:08
tritone added a commit to tritone/google-cloud-go that referenced this pull request Jun 22, 2023
This was causing some of the failures that I thought I had
addressed in googleapis#8159. Fix by specifying the bucket name using
CreateBucketRequest.BucketID rather than
CreateBucketRequest.Bucket.Name.

Also cleans up some messy logic around specifying bucket names
for integration tests that I ended up looking at.

Fixes googleapis#8162
tritone added a commit that referenced this pull request Jun 22, 2023
This was causing some of the failures that I thought I had
addressed in #8159. Fix by specifying the bucket name using
CreateBucketRequest.BucketID rather than
CreateBucketRequest.Bucket.Name.

Also cleans up some messy logic around specifying bucket names
for integration tests that I ended up looking at.

Fixes #8162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small.
Projects
None yet
2 participants