Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/gapicgen): only update relevant gapic files #4066

Merged
merged 5 commits into from
May 10, 2021
Merged

feat(internal/gapicgen): only update relevant gapic files #4066

merged 5 commits into from
May 10, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented May 6, 2021

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2021
@snippet-bot
Copy link

snippet-bot bot commented May 6, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 41 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codyoss codyoss marked this pull request as ready for review May 7, 2021 19:04
@codyoss codyoss requested a review from a team as a code owner May 7, 2021 19:04
@codyoss
Copy link
Member Author

codyoss commented May 7, 2021

Sample generation using this code:

Note that in the gapic PR there are far fewer diffs now. This will help create less noise for release PRs. Instead of regen triggering a release PR to update, now they will only update if their are relevant changes.

@codyoss codyoss requested a review from tbpg May 7, 2021 19:06
tbpg
tbpg approved these changes May 10, 2021
View reviewed changes
internal/gapicgen/git/git.go Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5948bee into master May 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the filter-update branch May 10, 2021 16:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codyoss @tbpg