Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): Correct the 'method' label value #11350

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix(bigtable): Correct the 'method' label value #11350

merged 2 commits into from
Dec 27, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Dec 27, 2024

This is what Bigtable Go library is writing to monitoring server while exporting client side metrics

           "metric": {
                "type": "bigtable.googleapis.com/internal/client/server_latencies",
                "labels": {
                    "app_profile": "",
                    "client_name": "go-bigtable/1.33.0",
                    "client_uid": "go-31437f26-8326-44d1-90f8-a277c8b1cd4e@bahaaiman-ct-01.c.googlers.com",
                    "method": "ReadRows", <==================== Incorrect
                    "status": "OK",
                    "streaming": "true"
                }
            },

The method label exported by Java client is "Bigtable.ReadRows".

Updating the Go client in this PR to match Java implementation.

@bhshkh bhshkh requested review from a team as code owners December 27, 2024 07:41
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 27, 2024
bhshkh
bhshkh commented Dec 27, 2024
View reviewed changes
bigtable/metrics_test.go
@@ -201,9 +202,8 @@ func TestNewBuiltinMetricsTracerFactory(t *testing.T) {
t.Errorf("builtinEnabled: got: %v, want: %v", gotClient.metricsTracerFactory.enabled, test.wantBuiltinEnabled)
}

if diff := testutil.Diff(gotClient.metricsTracerFactory.clientAttributes, wantClientAttributes,
cmpopts.IgnoreUnexported(attribute.KeyValue{}, attribute.Value{})); diff != "" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this as all the fields in attribute.Value are unexported and nothing was getting compared

https://github.com/open-telemetry/opentelemetry-go/blob/v1.29.0/attribute/value.go#L21-L27

@bhshkh bhshkh enabled auto-merge (squash) December 27, 2024 16:26
@bhshkh bhshkh merged commit 6aa27dc into googleapis:main Dec 27, 2024
8 of 10 checks passed
@bhshkh bhshkh deleted the feature/cbt-csm-03 branch December 27, 2024 16:43
@release-please release-please bot mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhshkh @mutianf