Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds suppliers for custom subject token and AWS credentials #1795

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

aeitzman
Copy link
Contributor

No description provided.

aeitzman and others added 3 commits March 27, 2024 11:23
* feat: refactor aws and identity pool credentials to use suppliers

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Daniel Bankhead <[email protected]>

* updating suppliers to use options objects

* updating docs

* moved transporter to context object and deprecated consts

* fix imports

---------

Co-authored-by: Leo <[email protected]>
Co-authored-by: Daniel Bankhead <[email protected]>
…h custom suppliers. (#1783)

* feat: adds support for users to build credentials with custom suppliers

Also adds default values to make it easier to instantiate credentials in code.

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* responding to review comments

---------

Co-authored-by: Leo <[email protected]>
* docs: adding documentation for programmatic auth feature

* fix typos

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>
Co-authored-by: Daniel Bankhead <[email protected]>

* add audience placeholder

---------

Co-authored-by: Leo <[email protected]>
Co-authored-by: Daniel Bankhead <[email protected]>
@aeitzman aeitzman requested review from a team as code owners April 16, 2024 16:24
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Apr 16, 2024
Copy link

Warning: This pull request is touching the following templated files:

Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; one lint warning

@aeitzman aeitzman merged commit c680b5d into main Apr 18, 2024
18 checks passed
@aeitzman aeitzman deleted the programmatic-auth branch April 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants