chore: restore generating integrations:v1alpha #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
approved these changes
Jun 21, 2023
quartzmo
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Jun 26, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
refs: #2037 refs: #2014 Unfortunately, reinstating `integrations/v1alpha` broke the build again. Therefore I will revert PR #2037 and skip it again in the generation. ``` 2023/06/26 07:09:48 Generating API integrations:v1alpha panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0xd8 pc=0x6c06c7] goroutine 1 [running]: main.(*Method).NewBodyArg(0xc0004674a0?, 0xc02b641590) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:2437 +0x27 main.(*Method).NewArguments(0xc0001fdc20) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:2430 +0x297 main.(*Method).generateCode(0xc0001fdc20) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:1835 +0x236 main.(*API).generateResourceMethods(0xc00024c630, 0xc02657e320) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:1596 +0x1aa main.(*API).generateResourceMethods(0xc00024c630, 0xc02657e0f0) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:1599 +0x1f8 main.(*API).generateResourceMethods(0xc00024c630, 0xc02657e0a0) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:1599 +0x1f8 main.(*API).GenerateCode(0xc00024c630) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:825 +0x2b3c main.(*API).WriteGeneratedCode(0xc00024c630) /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:578 +0x206 main.main() /tmpfs/src/github/google-api-go-client/google-api-go-generator/gen.go:148 +0x336 make: *** [Makefile:12: all] Error 2 2023/06/26 07:09:48 unable to generate discovery clients: exit status 2 exit status 1 cleanup ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2014
Comment on b/286436239 from Integrations team: "I have reverted the change that is expected to cause this break".