feat: Extend instanceof
Support for GaxiosError
#593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
instanceOf
Support forGaxiosError
There are a number of reasons
instanceof
could provide false-negatives:This PR aims to keep
instanceof
consistent and predictable across builds, in a supported, conventional way:Background for why this is needed:
GaxiosError
!=GaxiosError
google-auth-library-nodejs#1707Future Follow-ups
In the future we could create a utility to support the functionality for any class. E.g.:
🦕