-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: populate GaxiosResponse with raw response information (res.url) #189
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
836fca1
to
6c8c949
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@marapper don't worry about the license header, not your issue; thanks for the patch. |
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 96.59% 96.64% +0.05%
==========================================
Files 4 4
Lines 587 597 +10
Branches 100 100
==========================================
+ Hits 567 577 +10
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing jumps out at me in final review, why populate status
and statusText
twice, if we already have them on the top level object?
Yes, I just forgot to remove it. In axios it is populating twice but I think it's redundant. Updated. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
35138ea
to
bfcd2f6
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@marapper thank you for the contribution \o/ this will be released shortly after the holidays. |
To resolve #187
Adding
request.responseUrl
with real URL after redirects to response.