Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use retryDelay parameter properly #143

Closed
michaeleekk opened this issue Jul 17, 2019 · 0 comments · Fixed by #203
Closed

Use retryDelay parameter properly #143

michaeleekk opened this issue Jul 17, 2019 · 0 comments · Fixed by #203
Assignees
@JustinBeckwith
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@michaeleekk
Copy link

michaeleekk commented Jul 17, 2019 •
edited by JustinBeckwith
Loading

When I look for how the retry is implemented with exponential delay, I found that retryDelay is not used when calculating the delay.

Maybe the delay could be an addition or multiplication with the retryDelay parameter ? This could let anyone modify the initial delay, or the delay time between retries.

Alternatively, maybe removing the retryDelay from the README and in the code would be less misleading ?

I don't think this break anything, but I guess this would produce a better code quality.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 17, 2019
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. triage me labels Jul 19, 2019
@JustinBeckwith JustinBeckwith mentioned this issue Dec 16, 2019
Merged
@JustinBeckwith JustinBeckwith mentioned this issue Dec 16, 2019
Closed
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove retryDelay option googleapis/gaxios
3 participants
@JustinBeckwith @michaeleekk @yoshi-automation