Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable universe domain check for MDS #575

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jul 17, 2024

see b/349488459

BEGIN_COMMIT_OVERRIDE
fix: disable universe domain check for MDS (#575)
END_COMMIT_OVERRIDE

Copy link
Contributor Author

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the check even when a user has suppled a universe domain

src/CredentialsWrapper.php Outdated Show resolved Hide resolved
src/CredentialsWrapper.php Outdated Show resolved Hide resolved
@bshaffer bshaffer marked this pull request as ready for review July 23, 2024 13:36
@bshaffer bshaffer requested review from a team as code owners July 23, 2024 13:37
@bshaffer bshaffer merged commit a47a469 into main Aug 5, 2024
13 checks passed
@bshaffer bshaffer deleted the remove-mds-universe-domain-check branch August 5, 2024 16:26
@bshaffer bshaffer added the release-please:force-run To run release-please label Aug 13, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants