Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sets api header "gcloud-php-new" and "gcloud-php-legacy" to differentiate new surface versions #470

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 6, 2023

Adds an entry to User-Agent for gcloud-php-new/[version] and gcloud-php-legacy/[version]. This will have the result of populating the "client_library_name" (currently unused for GAPIC clients) so we can track the migration.

  • verify this shows up in the backend

Edit: This shows up as expected, but it changes the client type to "veneer", which is not accurate, so until that is fixed, this PR is blocked.

  • verify this shows up in the backend without changing the client type to "veneer"

@bshaffer bshaffer changed the title feat: add +s1 and +s2 for new surface versions feat: sets client_library_name to gcloud-php-s2 for new surface versions Jul 5, 2023
@bshaffer bshaffer changed the title feat: sets client_library_name to gcloud-php-s2 for new surface versions feat: sets api header "gcloud-php-s2" for new surface versions Jul 5, 2023
@bshaffer bshaffer marked this pull request as ready for review July 5, 2023 19:09
@bshaffer bshaffer requested review from a team as code owners July 5, 2023 19:09
@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 5, 2023
@bshaffer
Copy link
Contributor Author

bshaffer commented Jul 5, 2023

We have to verify the data is showing up in the backend as expected before merging this

@bshaffer bshaffer changed the title feat: sets api header "gcloud-php-s2" for new surface versions feat: sets api header "gcloud-php-new" and "gcloud-php-legacy" to differentiate new surface versions Jul 10, 2023
@bshaffer bshaffer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 31, 2023
@bshaffer bshaffer enabled auto-merge (squash) July 31, 2023 17:11
@bshaffer bshaffer merged commit 2d8ccff into main Jul 31, 2023
12 checks passed
@bshaffer bshaffer deleted the add-surface-version branch July 31, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants