feat: sets api header "gcloud-php-new" and "gcloud-php-legacy" to differentiate new surface versions #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
bshaffer
changed the title
noahdietz
approved these changes
Jul 5, 2023
bshaffer
added
the
do not merge
|
We have to verify the data is showing up in the backend as expected before merging this |
6 tasks
bshaffer
changed the title
1 task
bshaffer
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an entry to
User-Agentforgcloud-php-new/[version]andgcloud-php-legacy/[version]. This will have the result of populating the "client_library_name" (currently unused for GAPIC clients) so we can track the migration.Edit: This shows up as expected, but it changes the client type to "veneer", which is not accurate, so until that is fixed, this PR is blocked.