Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify ResourceHelperTrait registration #447

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

noahdietz
Copy link
Contributor

Simplifies template registration for GAPICs by pushing decriptor config loading into the ResourceHelperTrait.

@noahdietz
Copy link
Contributor Author

No idea what Test Suite / PHPStan Static Analysis is going on about.

@noahdietz
Copy link
Contributor Author

No idea what Test Suite / PHPStan Static Analysis is going on about.

I guess removing the phpstan annotation to ignore the next line fixed phpstan complaining about "nothing to ignore"

@bshaffer
Copy link
Contributor

@noahdietz that makes sense. My guess is something changed in the protobuf library to fix the static analysis error that was being thrown there

@noahdietz noahdietz merged commit 4949dc0 into googleapis:main Mar 16, 2023
@noahdietz noahdietz deleted the simplify-register-templates branch March 16, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants