feat: export fallback from fallback (circular) #803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our code is not perfectly fit for Electron because Electron's client side, even though it's technically a browser, does not respect
"browser":
field inpackage.json
, so it does not get redirected tobuild/src/fallback.js
automatically. This was reported here: googleapis/nodejs-speech#547The workaround for this is to prepare a bundle first (with either
webpack
orbrowserify
), but long term solution would be to change fallback detection logic in the client a little bit. To do it safely, I need this circular export:With this change, we'll be safely forcing users to
gax.fallback
in the client code ifwindow
is defined, without caring much if the"browser":
field worked or not.