fix(deps): remove rimraf in favor of native node rm function (#1626)

* fix(deps): remove rimraf in favor of native node rm function

* use fsp.rm instead of rmSync

* pin additional deps

* move pinned deps to devDeps

Author: ddelgrosso1

gax/package.json

@@ -39,9 +39,12 @@
     "c8": "^9.0.0",
     "codecov": "^3.1.0",
     "execa": "^5.0.0",
+    "glob": "10.4.0",
     "google-proto-files": "^4.2.0",
     "gts": "^5.0.0",
+    "jackspeak": "3.4.0",
     "linkinator": "^4.0.0",
+    "lru-cache": "10.3.0",
     "long": "^4.0.0",
     "mkdirp": "^2.0.0",
     "mocha": "^9.0.0",
@@ -50,7 +53,6 @@
     "protobufjs-cli": "1.1.2",
     "proxyquire": "^2.0.1",
     "pumpify": "^2.0.0",
-    "rimraf": "^5.0.1",
     "sinon": "^18.0.0",
     "stream-events": "^1.0.4",
     "ts-loader": "^8.0.0",

gax/test/showcase-server/package.json

@@ -18,12 +18,14 @@
   },
   "dependencies": {
     "download": "^8.0.0",
-    "execa": "^5.0.0",
-    "rimraf": "^5.0.1"
+    "execa": "^5.0.0"
   },
   "devDependencies": {
     "@types/download": "^8.0.1",
     "@types/node": "^14.11.2",
     "typescript": "^4.0.3"
+  },
+  "engines": {
+     "node": ">=14"
   }
 }

gax/test/showcase-server/src/index.ts

@@ -17,8 +17,8 @@
 import * as execa from 'execa';
 import * as download from 'download';
 import * as fs from 'fs';
+import * as fsp from 'fs/promises';
 import * as path from 'path';
-import {rimraf} from 'rimraf';
 import * as util from 'util';
 
 const mkdir = util.promisify(fs.mkdir);
@@ -41,7 +41,7 @@ export class ShowcaseServer {
     const fallbackServerUrl = `https://github.com/googleapis/gapic-showcase/releases/download/v${showcaseVersion}/${tarballFilename}`;
     const binaryName = './gapic-showcase';
 
-    await rimraf(testDir);
+    await fsp.rm(testDir, {recursive: true, force: true});
     await mkdir(testDir);
     process.chdir(testDir);
     console.log(`Server will be run from ${testDir}.`);

gax/test/system-test/test.clientlibs.ts

@@ -16,8 +16,8 @@
 
 import * as execa from 'execa';
 import * as fs from 'fs';
+import * as fsp from 'fs/promises';
 import * as path from 'path';
-import {rimraf} from 'rimraf';
 import * as util from 'util';
 import {describe, it, before} from 'mocha';
 
@@ -189,7 +189,7 @@ describe('Run system tests for some libraries', () => {
       throw new Error(`npm pack tarball ${toolsTarball} does not exist`);
     }
 
-    await rimraf(testDir);
+    await fsp.rm(testDir, {recursive: true, force: true});
     await mkdir(testDir);
     process.chdir(testDir);
     console.log(`Running tests in ${testDir}.`);

gax/test/unit/grpc.ts

@@ -24,7 +24,7 @@ import * as path from 'path';
 import * as proxyquire from 'proxyquire';
 import * as sinon from 'sinon';
 import {mkdirSync, writeFileSync} from 'fs';
-import {sync as rimrafSync} from 'rimraf';
+import * as fsp from 'fs/promises';
 import {afterEach, describe, it, beforeEach} from 'mocha';
 
 import {protobuf} from '../../src/index';
@@ -683,7 +683,7 @@ dvorak
       const [cert, key] = await client._detectClientCertificate();
       assert.ok(cert.includes('qwerty'));
       assert.ok(key.includes('dvorak'));
-      rimrafSync(tmpFolder); // Cleanup.
+      await fsp.rm(tmpFolder, {recursive: true, force: true}); // Cleanup.
     });
     it('throws if attempted to use mTLS in non-default universe', async () => {
       // Pretend that "tmp-secure-context" in the current folder is the
@@ -702,7 +702,7 @@ dvorak
         client.createStub(DummyStub, {universeDomain: 'example.com'}),
         /configured universe domain/
       );
-      rimrafSync(tmpFolder); // Cleanup.
+      await fsp.rm(tmpFolder, {recursive: true, force: true}); // Cleanup.
     });
   });
 });

tools/package.json

@@ -33,7 +33,6 @@
     "google-gax": "^4.3.2",
     "google-proto-files": "^4.2.0",
     "protobufjs-cli": "1.1.2",
-    "rimraf": "^5.0.1",
     "uglify-js": "^3.17.0",
     "walk-up-path": "^3.0.1",
     "walkdir": "^0.4.0"

tools/test/compileProtos.ts

@@ -18,7 +18,6 @@ import * as assert from 'assert';
 import {describe, it, beforeEach, afterEach} from 'mocha';
 import * as fs from 'fs';
 import * as fsp from 'fs/promises';
-import {rimraf} from 'rimraf';
 import {ncp} from 'ncp';
 import * as util from 'util';
 import * as path from 'path';
@@ -42,7 +41,7 @@ const expectedCommonJSResultFile = path.join(resultDir, 'protos.cjs');
 describe('compileProtos tool', () => {
   beforeEach(async () => {
     if (fs.existsSync(testDir)) {
-      await rimraf(testDir);
+      await fsp.rm(testDir, {recursive: true, force: true});
     }
     await mkdir(testDir);
     await mkdir(resultDir);

tools/test/minify.ts

@@ -16,7 +16,6 @@ import * as assert from 'assert';
 import {describe, it, beforeEach} from 'mocha';
 import * as fs from 'fs';
 import {promises as fsp} from 'fs';
-import {rimraf} from 'rimraf';
 import * as path from 'path';
 import * as minify from '../src/minify';
 
@@ -26,7 +25,7 @@ const fixturesDir = path.join(__dirname, '..', 'test', 'fixtures');
 describe('minify tool', () => {
   beforeEach(async () => {
     if (fs.existsSync(testDir)) {
-      await rimraf(testDir);
+      await fsp.rm(testDir, {recursive: true, force: true});
     }
     await fsp.mkdir(testDir);
   });